feat: add GNU_PROPERTY_X86_ISA_1_NEEDED detection #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISA extensions usage is not defined by a PEP yet. This first implementation fails to repair the wheel if the usage of x86-64-v[2-4] is required. The check can be disabled with `--disable-isa-ext-check`. The detection being related to a declaration when building, it will not detect the requirement for binaries where the declaration is missing. All executables built on a manylinux_2_34 image will be detected as x86-64-v2.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
==========================================
+ Coverage 92.05% 92.09% +0.04%
==========================================
Files 20 22 +2
Lines 1321 1543 +222
Branches 248 291 +43
==========================================
+ Hits 1216 1421 +205
- Misses 65 73 +8
- Partials 40 49 +9 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
|
@lkollar, would you have time to review this in the coming weeks please ? |
|
Hey @mayeut, yes, I'll take a look. |
lkollar
reviewed
Feb 9, 2025
lkollar
approved these changes
Feb 9, 2025
|
Thanks for the review @lkollar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISA extensions usage is not defined by a PEP yet.
This first implementation fails to repair the wheel if the usage of x86-64-v[2-4] is required.
The check can be disabled with
--disable-isa-ext-check.The detection being related to a declaration when building, it will not detect the requirement for binaries where the declaration is missing.
All executables built on a manylinux_2_34 image will be detected as x86-64-v2.